Skip to content

Remove MIRKN blanket reexports - #578

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/mirkn-explicit-public-api
Jul 30, 2026
Merged

Remove MIRKN blanket reexports#578
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/mirkn-explicit-public-api

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

  • remove MIRKN blanket reexports and the unused Reexport dependency
  • import SciMLBase test APIs directly from their owning module
  • remove MIRKN reexport and public-doc QA exemptions
  • correct and expand the rendered MIRKN constructor documentation at its definition point

Undocumented dependency reexports are removed as API cleanup; this does not remove a documented interface.

Validation

  • BOUNDARYVALUEDIFFEQ_TEST_GROUP=Core julia +1.12 --project=lib/BoundaryValueDiffEqMIRKN -e 'using Pkg; Pkg.test()' (25/25)\n- BOUNDARYVALUEDIFFEQ_TEST_GROUP=QA julia +1.12 --project=lib/BoundaryValueDiffEqMIRKN -e 'using Pkg; Pkg.test()' (20/20)\n- MIRKN docstring example expressions\n- Runic and git diff --check\n\nIgnore until reviewed by @ChrisRackauckas.

@ChrisRackauckas
Remove MIRKN blanket reexports
03b0031 
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.11)

Time benchmarks
master 03b0031... master / 03b0031...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.578 ± 0.0064 s 0.579 ± 0.0012 s 0.999 ± 0.011
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 12.1 ± 0.23 ms 12.1 ± 0.19 ms 1 ± 0.025
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 2.67 ± 0.14 ms 2.66 ± 0.064 ms 1 ± 0.058
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 3.16 ± 0.086 ms 3.36 ± 0.19 ms 0.942 ± 0.06
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.55 ± 0.048 ms 1.54 ± 0.047 ms 1 ± 0.044
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.49 ± 0.046 ms 1.55 ± 0.065 ms 0.964 ± 0.05
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.15 ± 0.12 ms 3.13 ± 0.11 ms 1 ± 0.051
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0388 ± 0.0026 s 0.0388 ± 0.0026 s 1 ± 0.096
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.0613 ± 0.0026 s 0.0595 ± 0.0017 s 1.03 ± 0.053
Simple Pendulum/IIP/Shooting(Tsit5()) 0.175 ± 0.074 ms 0.178 ± 0.074 ms 0.985 ± 0.58
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.746 ± 0.018 s 0.71 ± 0.013 s 1.05 ± 0.032
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 15.6 ± 4.5 ms 15.3 ± 4.3 ms 1.02 ± 0.41
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 3.19 ± 0.2 ms 3.21 ± 0.13 ms 0.993 ± 0.074
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 3.97 ± 0.31 ms 4.02 ± 0.29 ms 0.988 ± 0.1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 1.9 ± 0.17 ms 1.85 ± 0.091 ms 1.03 ± 0.11
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.46 ± 0.61 ms 3.39 ± 0.62 ms 1.02 ± 0.26
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 6.65 ± 5.4 ms 6.27 ± 5.1 ms 1.06 ± 1.2
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0826 ± 0.0025 s 0.0813 ± 0.0023 s 1.02 ± 0.042
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.13 ± 0.005 s 0.133 ± 0.004 s 0.973 ± 0.047
Simple Pendulum/OOP/Shooting(Tsit5()) 0.621 ± 0.08 ms 0.593 ± 0.04 ms 1.05 ± 0.15
time_to_load 7.23 ± 0.042 s 7.28 ± 0.22 s 0.994 ± 0.03
Memory benchmarks
master 03b0031... master / 03b0031...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.389 M allocs: 0.0443 GB 0.389 M allocs: 0.0443 GB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 0.0436 M allocs: 4.88 MB 0.0436 M allocs: 4.88 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 15.7 k allocs: 1.65 MB 15.7 k allocs: 1.65 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 22.1 k allocs: 2.04 MB 22.1 k allocs: 2.04 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 12.8 k allocs: 1.05 MB 12.8 k allocs: 1.05 MB 1
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 25.5 k allocs: 1.83 MB 25.5 k allocs: 1.83 MB 1
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 0.049 M allocs: 3.39 MB 0.049 M allocs: 3.39 MB 1
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.553 M allocs: 0.0535 GB 0.553 M allocs: 0.0535 GB 1
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.833 M allocs: 0.0778 GB 0.833 M allocs: 0.0778 GB 1
Simple Pendulum/IIP/Shooting(Tsit5()) 4.64 k allocs: 0.224 MB 4.64 k allocs: 0.224 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.89 M allocs: 0.984 GB 0.89 M allocs: 0.984 GB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 0.0932 M allocs: 24.8 MB 0.0932 M allocs: 24.8 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 0.0324 M allocs: 3.96 MB 0.0324 M allocs: 3.96 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 0.045 M allocs: 4.99 MB 0.045 M allocs: 4.99 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 25.3 k allocs: 2.17 MB 25.3 k allocs: 2.17 MB 1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 0.142 M allocs: 10.2 MB 0.142 M allocs: 10.2 MB 1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 0.266 M allocs: 18.7 MB 0.266 M allocs: 18.7 MB 1
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 2.52 M allocs: 0.279 GB 2.52 M allocs: 0.279 GB 1
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 3.82 M allocs: 0.404 GB 3.82 M allocs: 0.404 GB 1
Simple Pendulum/OOP/Shooting(Tsit5()) 0.0373 M allocs: 1.69 MB 0.0373 M allocs: 1.69 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 30, 2026 10:05
@ChrisRackauckas
ChrisRackauckas merged commit a29b96b into SciML:master Jul 30, 2026
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisRackauckas-Claude @ChrisRackauckas